Remove intercept_logs routine #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
====================================
Coverage 75% 75%
====================================
Files 10 10
Lines 172 172
Branches 21 21
====================================
Hits 129 129
Misses 29 29
Partials 14 14Continue to review full report at Codecov.
|
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
It wasn't used a lot, and it also triggered a coverity error: ``` CID 1440844 (pmem#1 of 1): Overflowed array index write (INTEGER_OVERFLOW) Overflowed or truncated value (or a value computed from an overflowed or truncated value) len - 1UL used as array index. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve piece with coverity
This change is