Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel building tests and pcheck in packages #736

Merged
merged 2 commits into from
Apr 1, 2016

Conversation

plebioda
Copy link
Contributor

@plebioda plebioda commented Apr 1, 2016

This change is Reviewable

When building in test directory with multiple jobs, the build sometimes
failed. There was the following error when linking pmemdetect tool
on one of its object files:

*.o: file not recognized: File truncated

The problem was that each and every test depends on pmemdetect tool and
there is a rule in src/test/Makefile.inc which builds the pmemdetect
from the test directory.

The tests and tools were building in parallel and thus somethimes the
pmemdetect was build twice (at least) and make could not synchronize
this because the rules were in different makefiles.

This patch fixes the dependencies in src/test/Makefile which fixes the
issue.
... because make pcheck with multiple jobs may fail due to "No space on
device error". We need to figure it out how to resolve this problem.
Until then run tests in sequentially.
@krzycz krzycz merged commit 0bec681 into pmem:master Apr 1, 2016
@plebioda plebioda deleted the fix-test-makefile-dependencies branch April 17, 2016 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants