pmem2: enable movdir64b compilation but disable it in the runtime

[lplewa]

This change is 

[lgtm-com]

This pull request introduces 2 alerts when merging 4cfddc7 into b2b1563 - view on LGTM.com

new alerts:

• 2 for Duplicate include guard

[lgtm-com]

This pull request introduces 2 alerts when merging cb304f9 into b2b1563 - view on LGTM.com

new alerts:

• 2 for Duplicate include guard

[lgtm-com]

This pull request introduces 2 alerts when merging 9ad3fb7 into b2b1563 - view on LGTM.com

new alerts:

• 2 for Duplicate include guard

[codecov]

Codecov Report

Merging #5471 (29c453f) into stable-1.12 (91f4159) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           stable-1.12    #5471      +/-   ##
===============================================
+ Coverage        72.22%   72.28%   +0.05%     
===============================================
  Files              193      195       +2     
  Lines            30335    30215     -120     
===============================================
- Hits             21909    21840      -69     
+ Misses            8426     8375      -51     

[kswiecicki]

src/test/pmem2_memcpy/TESTS.py line 80 at r1 (raw file):

@t.add_params('wc_workaround', ['on', 'off', 'default'])
class TEST5(Pmem2Memcpy):
    envs1 = ("PMEM_MOVDIR64B",)

Have you tested if tests with PMEM_MOVDIR64B=1 are not failing on the platforms lacking movdir64b instruction?
I'm wondering if the tests are aware that even if PMEM_MOVDIR64B is set to 1 it still won't be used if the platform doesn't support it.

Code quote:

@t.require_architectures('x86_64')
@t.add_params('wc_workaround', ['on', 'off', 'default'])
class TEST5(Pmem2Memcpy):
    envs1 = ("PMEM_MOVDIR64B",)

[kswiecicki]

Could you fix the #ifndef PMEM2_MEMSET_AVX512F_H define in the memset_movdir64b.h, LGTM is reporting this issue.
I must have left it unchanged by accident when I created this header.

[lplewa]

Reviewable status: 0 of 20 files reviewed, 1 unresolved discussion (waiting on @kswiecicki)

---

src/test/pmem2_memcpy/TESTS.py line 80 at r1 (raw file):

Previously, kswiecicki (Krzysztof Święcicki) wrote…

Have you tested if tests with PMEM_MOVDIR64B=1 are not failing on the platforms lacking movdir64b instruction?
I'm wondering if the tests are aware that even if PMEM_MOVDIR64B is set to 1 it still won't be used if the platform doesn't support it.

Yeah. it works. Our tests are very simple. We are not checking which instruction is used, but only a correction of operation.

In your case, if forced instruction is not available, PMDK is selecting a different one.

[lplewa]

Could you fix the #ifndef PMEM2_MEMSET_AVX512F_H define in the memset_movdir64b.h, LGTM is reporting this issue. I must have left it unchanged by accident when I created this header.

done

[kswiecicki]