Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: fix clang format version issue #3541

Merged
merged 1 commit into from
Jan 30, 2019
Merged

common: fix clang format version issue #3541

merged 1 commit into from
Jan 30, 2019

Conversation

wlemkows
Copy link
Contributor

@wlemkows wlemkows commented Jan 30, 2019 •
edited by marcinslusarz
Loading

Ref: pmem/issues#1004

This change is Reviewable

@wlemkows wlemkows changed the base branch from master to stable-1.5 January 30, 2019 13:46
@pmem-bot
Copy link
Contributor

@pbalcer and @kilobyte please review this pull request

kilobyte
kilobyte reviewed Jan 30, 2019
View reviewed changes
Copy link
Contributor

@kilobyte kilobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kilobyte
Copy link
Contributor

Note that the B-Dep on clang-format rather than clang-format-6.0 means newer Ubuntus will install the incorrect version, but that'll result in the test being skipped — probably preferable over failing.

wlemkows
wlemkows commented Jan 30, 2019
View reviewed changes
Copy link
Contributor Author

@wlemkows wlemkows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but if the latest fedora and ubuntu will have the clang-format version 7.X installed and we will upgrade the docker images then we can also update clang-format version.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@codecov-io
Copy link

Codecov Report

Merging #3541 into stable-1.5 will increase coverage by 0.22%.
The diff coverage is 93.62%.

@@              Coverage Diff               @@
##           stable-1.5    #3541      +/-   ##
==============================================
+ Coverage       74.26%   74.48%   +0.22%     
==============================================
  Files             155      156       +1     
  Lines           26387    26597     +210     
==============================================
+ Hits            19596    19812     +216     
+ Misses           6791     6785       -6

marcinslusarz
marcinslusarz approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@marcinslusarz marcinslusarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@marcinslusarz marcinslusarz merged commit a655a5d into pmem:stable-1.5 Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilobyte kilobyte kilobyte left review comments

@marcinslusarz marcinslusarz marcinslusarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wlemkows @pmem-bot @kilobyte @codecov-io @marcinslusarz