obj: add Wswitch-default warning flag #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2858 +/- ##
==========================================
- Coverage 77.14% 77.12% -0.02%
==========================================
Files 175 175
Lines 25206 25216 +10
==========================================
+ Hits 19444 19447 +3
- Misses 5762 5769 +7 |
|
Reviewed 13 of 13 files at r1. Comments from Reviewable |
src/libpmemobj/ctl.c
Outdated
| ERR("invalid destination size %zu", dest_size); | ||
| errno = EINVAL; | ||
| return -1; | ||
| break; |
There was a problem hiding this comment.
return followed by break? :)
mbiesek
force-pushed
the
feat-switch-default-case
branch
from
5d0ca75 to
0e7c375
Compare
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intention of this PR is to extend diagnostic during compilation.
Wswitch-default is responsible to point a place where switch statement do not have a default case, which might lead to complex logical errors and resultant weaknesses.
This warning is currently disabled in project.
In any case any feedback will be appreciated.
This change is