Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: replace NULL with nullptr #2836

Merged
merged 1 commit into from
Apr 9, 2018

Conversation

mbiesek
Copy link

@mbiesek mbiesek commented Apr 8, 2018

Intention of this PR is to replace NULL with nullptr.
Test/examples are compiled with -std=c++11, which means nullptr value is supported by these module.
I could prepare additional PR for benchmark module with similar changes and additional for makefile to change the std to c++11, but I don't know if it is possible, because of:
485a455

In any case any feedback will be appreciated.


This change is Reviewable

@codecov-io
Copy link

Codecov Report

Merging #2836 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2836      +/-   ##
==========================================
+ Coverage   77.21%   77.21%   +<.01%     
==========================================
  Files         175      175              
  Lines       25174    25175       +1     
==========================================
+ Hits        19437    19438       +1     
  Misses       5737     5737

@marcinslusarz
Copy link
Contributor

:lgtm:

I'm not sure what's up with pmembench. @krzycz?


Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@krzycz
Copy link
Contributor

krzycz commented Apr 9, 2018

I can't remember what was the actual problem, but since the examples are compiled with -std=c++11 and it works with Coverity, then we can probably do the same for pmembench.


Reviewed 11 of 11 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@krzycz krzycz merged commit 8ecb108 into pmem:master Apr 9, 2018
@mbiesek mbiesek deleted the feat-nullptr_replaceNULL branch April 12, 2018 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants