blk: change how the EZ flags are handled in the blk map #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| remaining = mlen; | ||
| next_index = 0; | ||
| } | ||
| mapp[next_index++] = htole32(i | BTT_MAP_ENTRY_ZERO); |
There was a problem hiding this comment.
My intention (which I realize I didn't state very clearly) was that the map either known to be initialized to zero, or you initialize it to zero. I think that write_map() no longer needs to store the identity values because you assume the value is the identity when btt_is_initial() returns true.
So I like the logic you have, I just think write_map() should simply zero the map.
Given this, I wonder if we should introduce an nszero callback so the caller can use whatever optimized methods are available for zeroing pmem. What do you think?
There was a problem hiding this comment.
I think that it’s a good idea. I’ll use the pmem_memset for the nszero callback in pmemblk. The new sse versions written by Sarah should be pretty good for this.
tomaszkapela
force-pushed
the
blk-map-write-change
branch
from
cb4a657 to
fd6f18d
Compare
andyrudoff
pushed a commit
that referenced
this pull request
Jan 21, 2015
blk: change how the EZ flags are handled in the blk map
lplewa
added a commit
to lplewa/pmdk
that referenced
this pull request
Aug 25, 2022
a8d51f0a4 Merge pull request pmem#111 from kswiecicki/kw-issues b1efa1c99 Merge pull request pmem#109 from KFilipek/add-casting dc88b63a0 masync: fix hashmap memory allocation 97055b841 masync: assert hashmap example copied value 701844c99 masync: fix hashmap example allocation checking 93b1698ff masync: fix hashmap example cleanup 7fa75e02f masync: avoid casting error on C++ compilation git-subtree-dir: src/deps/miniasync git-subtree-split: a8d51f0a46d8143cbbc5ac8ca272ad3ba19fed6e
lplewa
added a commit
to lplewa/pmdk
that referenced
this pull request
Aug 25, 2022
a8d51f0a4 Merge pull request pmem#111 from kswiecicki/kw-issues b1efa1c99 Merge pull request pmem#109 from KFilipek/add-casting dc88b63a0 masync: fix hashmap memory allocation 97055b841 masync: assert hashmap example copied value 701844c99 masync: fix hashmap example allocation checking 93b1698ff masync: fix hashmap example cleanup 7fa75e02f masync: avoid casting error on C++ compilation git-subtree-dir: src/deps/miniasync git-subtree-split: a8d51f0a46d8143cbbc5ac8ca272ad3ba19fed6e
hswong3i
pushed a commit
to alvistack/pmem-pmdk
that referenced
this pull request
Feb 28, 2024
a8d51f0a4 Merge pull request pmem#111 from kswiecicki/kw-issues b1efa1c99 Merge pull request pmem#109 from KFilipek/add-casting dc88b63a0 masync: fix hashmap memory allocation 97055b841 masync: assert hashmap example copied value 701844c99 masync: fix hashmap example allocation checking 93b1698ff masync: fix hashmap example cleanup 7fa75e02f masync: avoid casting error on C++ compilation git-subtree-dir: src/deps/miniasync git-subtree-split: a8d51f0a46d8143cbbc5ac8ca272ad3ba19fed6e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change reduces the time to write out the initial map in a zero-filled pool to zero.