Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

Merge back changes from Stable 1.6 #291

Merged
merged 6 commits into from
May 15, 2019
Merged

Merge back changes from Stable 1.6 #291

merged 6 commits into from
May 15, 2019

Conversation

igchor
Copy link
Contributor

@igchor igchor commented Apr 25, 2019

This change is Reviewable

igchor and others added 6 commits March 15, 2019 11:04
C++ version was incorrectly computed by cmake to c++98 which resulted in compilation error on ubuntu 16.04
[1.6] Bump pmdk to 1.6 in Docker images
[1.6] cmake: require c++11 for cow check
@pmem-bot
Copy link
Contributor

@pbalcer and @wlemkows please review this pull request

@codecov
Copy link

codecov bot commented Apr 25, 2019

Codecov Report

Merging #291 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
- Coverage   96.48%   96.45%   -0.04%     
==========================================
  Files          32       32              
  Lines        2991     3246     +255     
==========================================
+ Hits         2886     3131     +245     
- Misses        105      115      +10
Flag Coverage Δ
#tests_clang_debug_cpp17 96.44% <ø> (-0.05%) ⬇️
#tests_gcc_debug 96.46% <ø> (-0.69%) ⬇️
#tests_gcc_release_cpp17_no_valgrind 95.56% <ø> (+0.47%) ⬆️
Impacted Files Coverage Δ
.../libpmemobj++/experimental/concurrent_hash_map.hpp 94.36% <0%> (-1.31%) ⬇️
include/libpmemobj++/experimental/basic_string.hpp 100% <0%> (ø) ⬆️
include/libpmemobj++/detail/life.hpp 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d754bd...18bea23. Read the comment docs.

Copy link
Contributor

@kkajrewicz kkajrewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kkajrewicz kkajrewicz merged commit d0501c7 into master May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants