FBSW-317 Integrate CodeCov with CICD

.github/workflows/build-cachelib-centos-long.yml

@@ -0,0 +1,39 @@
+name: build-cachelib-centos-latest
+on:
+  schedule:
+    - cron:  '0 7 * * *'
+
+jobs:
+  build-cachelib-centos8-latest:
+    name: "CentOS/latest - Build CacheLib with all dependencies"
+    runs-on: ubuntu-latest
+    # Docker container image name
+    container: "centos:latest"
+    steps:
+      - name: "update packages"
+        run: dnf upgrade -y
+      - name: "install sudo,git"
+        run: dnf install -y sudo git cmake gcc
+      - name: "System Information"
+        run: |
+          echo === uname ===
+          uname -a
+          echo === /etc/os-release ===
+          cat /etc/os-release
+          echo === df -hl ===
+          df -hl
+          echo === free -h ===
+          free -h
+          echo === top ===
+          top -b -n1 -1 -Eg || timeout 1 top -b -n1
+          echo === env ===
+          env
+          echo === gcc -v ===
+          gcc -v
+      - name: "checkout sources"
+        uses: actions/checkout@v2
+      - name: "build CacheLib using build script"
+        run: ./contrib/build.sh -j -v -T
+      - name: "run tests"
+        timeout-minutes: 60
+        run: cd opt/cachelib/tests && ../../../run_tests.sh long

.github/workflows/build-cachelib-centos.yml

@@ -1,18 +1,15 @@
 name: build-cachelib-centos-latest
 on:
-  schedule:
-     - cron:  '30 5 * * 1,4'
+  push:
+  pull_request:
+
 jobs:
   build-cachelib-centos8-latest:
     name: "CentOS/latest - Build CacheLib with all dependencies"
     runs-on: ubuntu-latest
     # Docker container image name
-    container: "centos:latest"
+    container: "ghcr.io/igchor/cachelib-deps:centos8"
     steps:
-      - name: "update packages"
-        run: dnf upgrade -y
-      - name: "install sudo,git"
-        run: dnf install -y sudo git cmake gcc
       - name: "System Information"
         run: |
           echo === uname ===
@@ -31,5 +28,12 @@ jobs:
           gcc -v
       - name: "checkout sources"
         uses: actions/checkout@v2
+      - name: "download codecov using the download-codecov script"
+        run: ./download-codecov.sh
+      - name: "print workspace"
+        run: echo $GITHUB_WORKSPACE
       - name: "build CacheLib using build script"
-        run: ./contrib/build.sh -j -v -T
+        run: mkdir build && cd build && cmake ../cachelib -DBUILD_TESTS=ON -DCMAKE_INSTALL_PREFIX=/opt -DCMAKE_BUILD_TYPE=Debug && make install -j$(nproc)
+      - name: "run tests"
+        timeout-minutes: 120
+        run: cd /opt/tests && $GITHUB_WORKSPACE/run_tests.sh

.github/workflows/build-cachelib-debian.yml

@@ -1,7 +1,8 @@
 name: build-cachelib-debian-10
 on:
   schedule:
-     - cron:  '30 5 * * 2,6'
+    - cron:  '30 5 * * 0,3'
+
 jobs:
   build-cachelib-debian-10:
     name: "Debian/Buster - Build CacheLib with all dependencies"
@@ -37,3 +38,6 @@ jobs:
         uses: actions/checkout@v2
       - name: "build CacheLib using build script"
         run: ./contrib/build.sh -j -v -T
+      - name: "run tests"
+        timeout-minutes: 60
+        run: cd opt/cachelib/tests && ../../../run_tests.sh

cachelib/CMakeLists.txt

@@ -66,6 +66,9 @@ set(CMAKE_INSTALL_RPATH_USE_LINK_PATH FALSE)
 set(CACHELIB_HOME ${CMAKE_CURRENT_SOURCE_DIR})
 set(CACHELIB_BUILD ${CMAKE_CURRENT_BINARY_DIR})
 
+# Add code coverage
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -coverage")
+
 # Add root dir so qualified includes work.
 # E.g. #include "cachelib/allocator/foobar.h"
 include_directories(${CACHELIB_HOME}/..)

cachelib/allocator/CMakeLists.txt

@@ -109,6 +109,8 @@ if (BUILD_TESTS)
   add_test (tests/ChainedHashTest.cpp)
   add_test (tests/AllocatorResizeTypeTest.cpp)
   add_test (tests/AllocatorHitStatsTypeTest.cpp)
+  add_test (tests/AllocatorMemoryTiersTest.cpp)
+  add_test (tests/MemoryTiersTest.cpp)
   add_test (tests/MultiAllocatorTest.cpp)
   add_test (tests/NvmAdmissionPolicyTest.cpp)
   add_test (nvmcache/tests/NvmItemTests.cpp)

cachelib/allocator/Cache.cpp

@@ -23,6 +23,12 @@
 namespace facebook {
 namespace cachelib {
 
+CacheBase::CacheBase(unsigned numTiers): numTiers_(numTiers) {}
+
+unsigned CacheBase::getNumTiers() const {
+  return numTiers_;
+}
+
 void CacheBase::setRebalanceStrategy(
     PoolId pid, std::shared_ptr<RebalanceStrategy> strategy) {
   std::unique_lock<std::mutex> l(lock_);

cachelib/allocator/Cache.h

@@ -56,7 +56,7 @@ enum class RemoveContext { kEviction, kNormal };
 // A base class of cache exposing members and status agnostic of template type.
 class CacheBase {
  public:
-  CacheBase() = default;
+  CacheBase(unsigned numTiers = 1);
   virtual ~CacheBase() = default;
 
   // Movable but not copyable
@@ -65,6 +65,9 @@ class CacheBase {
   CacheBase(CacheBase&&) = default;
   CacheBase& operator=(CacheBase&&) = default;
 
+  // TODO: come up with some reasonable number
+  static constexpr unsigned kMaxTiers = 8;
+
   // Get a string referring to the cache name for this cache
   virtual const std::string getCacheName() const = 0;
 
@@ -253,6 +256,10 @@ class CacheBase {
   // @return The number of slabs that were actually reclaimed (<= numSlabs)
   virtual unsigned int reclaimSlabs(PoolId id, size_t numSlabs) = 0;
 
+  unsigned getNumTiers() const;
+
+  unsigned numTiers_ = 1;
+
   // Protect 'poolRebalanceStragtegies_' and `poolResizeStrategies_`
   // and `poolOptimizeStrategy_`
   mutable std::mutex lock_;