Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Improve UnitTestShouldUse{After,Before}Annotation rules to support JUnit5 and TestNG #5245

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

adangel
Copy link
Member

@adangel adangel commented Oct 3, 2024

Describe the PR

This is a follow up on #4965 .

Related issues

  • none

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added this to the 7.7.0 milestone Oct 3, 2024
@pmd-test
Copy link

pmd-test commented Oct 3, 2024

1 Message
📖 Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 12071 new violations, 0 new errors and 0 new configuration errors,
removes 12071 violations, 2 errors and 7 configuration errors.
Download full report as build artifact
Compared to main:
This changeset changes 0 violations,
introduces 12071 new violations, 0 new errors and 0 new configuration errors,
removes 12071 violations, 2 errors and 7 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@adangel adangel force-pushed the java-unit-test-rules branch from db03411 to 9337e5a Compare October 3, 2024 18:55
@adangel adangel marked this pull request as ready for review October 3, 2024 20:42
@adangel adangel added the an:enhancement An improvement on existing features / rules label Oct 18, 2024
@adangel adangel merged commit 40ed459 into pmd:main Oct 24, 2024
3 checks passed
@adangel adangel deleted the java-unit-test-rules branch October 24, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
an:enhancement An improvement on existing features / rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants