Perform the persistence asynchronously to not block the main (UI) thread #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids "your app is not responding" errors, while the git command is waiting for password input to load the gpg key for commit signing. This also reverts the fix from 7cc0463: Calling System#exit immediately after Platform#exit prevents Application#stop from being called. And we always exited with 0. Now the exit status is determined by DesignerStarter#launchGui and used correctly. Platform#exit triggers the shutdown of JavaFx. After that is done execution continues in DesignerStarter after Application#launch.
adangel
added a commit
that referenced
this pull request
Sep 28, 2023
adangel
added a commit
that referenced
this pull request
Sep 28, 2023
Perform the persistence asynchronously to not block the main (UI) thread #69
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids "your app is not responding" errors, while the git command is waiting for password input to load the gpg key for commit signing.
This also reverts the fix from 7cc0463: Calling System#exit immediately after Platform#exit prevents Application#stop from being called. And we always exited with 0. Now the exit status is determined by DesignerStarter#launchGui and used correctly. Platform#exit triggers the shutdown of JavaFx. After that is done execution continues in DesignerStarter after Application#launch.