Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change isExpanded dynamically + Support null safety #33

Merged
merged 4 commits into from
May 21, 2021

Conversation

zvikarp
Copy link
Contributor

@zvikarp zvikarp commented Jan 7, 2021

Hi, loving this package 😍!

In my app I need to change the expanded state with a custom button, to do so I made minor changes in the package code. I'm opening this request to merge the changes, I have tested it ant all works! You can change the value of isExpanded from the parent widget and it changes the calendar expanded state.

Also noticed that an issue on this subject was opened a few weeks ago, so this PR can close #31 .

@zvikarp
Copy link
Contributor Author

zvikarp commented Jan 7, 2021

I noticed that hideBottomBar is not in use, instead, we use isExpandable:

https://github.com/pmcarlos/flutter_clean_calendar/blob/master/lib/flutter_clean_calendar.dart#L272

I'm not changing it, as users might be relying on it, but it is something to notice, maybe for the next major version.

@zvikarp zvikarp changed the title Allow to change isExpanded dynamically Allow to change isExpanded dynamically + Support null safety Apr 4, 2021
@zvikarp
Copy link
Contributor Author

zvikarp commented Apr 4, 2021

Hi, A long time has passed since this PR was opened, I have also added null-safety to my fork.
This Pr closes #35 and doesn't use the date_util package anymore (it is implemented in this package), as it doesn't support null-safety yet.

@pmcarlos
Copy link
Owner

Thanks for this @zvikarp, and sorry for the delay

@pmcarlos pmcarlos merged commit 79892e9 into pmcarlos:master May 21, 2021
@zvikarp zvikarp mentioned this pull request Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is Expanded Don´t work dynamically
2 participants