chore: remove shallowClone util helper

pmalouin · Mar 9, 2020 · 79cbe09 · 79cbe09
1 parent 6aa2434
commit 79cbe09
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 14 deletions.
diff --git a/lib/gridfs-stream/index.js b/lib/gridfs-stream/index.js
@@ -3,7 +3,6 @@
 var Emitter = require('events').EventEmitter;
 var GridFSBucketReadStream = require('./download');
 var GridFSBucketWriteStream = require('./upload');
-var shallowClone = require('../utils').shallowClone;
 var toError = require('../utils').toError;
 var util = require('util');
 var executeLegacyOperation = require('../utils').executeLegacyOperation;
@@ -33,7 +32,7 @@ function GridFSBucket(db, options) {
   this.setMaxListeners(0);
 
   if (options && typeof options === 'object') {
-    options = shallowClone(options);
+    options = Object.assign({}, options);
     var keys = Object.keys(DEFAULT_GRIDFS_BUCKET_OPTIONS);
     for (var i = 0; i < keys.length; ++i) {
       if (!options[keys[i]]) {
@@ -85,7 +84,7 @@ util.inherits(GridFSBucket, Emitter);
 
 GridFSBucket.prototype.openUploadStream = function(filename, options) {
   if (options) {
-    options = shallowClone(options);
+    options = Object.assign({}, options);
   } else {
     options = {};
   }
@@ -113,7 +112,7 @@ GridFSBucket.prototype.openUploadStream = function(filename, options) {
 
 GridFSBucket.prototype.openUploadStreamWithId = function(id, filename, options) {
   if (options) {
-    options = shallowClone(options);
+    options = Object.assign({}, options);
   } else {
     options = {};
   }

diff --git a/lib/gridfs/grid_store.js b/lib/gridfs/grid_store.js
@@ -45,7 +45,6 @@ const util = require('util');
 const MongoError = require('../core').MongoError;
 const inherits = util.inherits;
 const Duplex = require('stream').Duplex;
-const shallowClone = require('../utils').shallowClone;
 const executeLegacyOperation = require('../utils').executeLegacyOperation;
 const deprecate = require('util').deprecate;
 
@@ -221,7 +220,7 @@ var open = function(self, options, callback) {
       // Get chunk collection
       var chunkCollection = self.chunkCollection();
       // Make an unique index for compatibility with mongo-cxx-driver:legacy
-      var chunkIndexOptions = shallowClone(writeConcern);
+      var chunkIndexOptions = Object.assign({}, writeConcern);
       chunkIndexOptions.unique = true;
       // Ensure index on chunk collection
       chunkCollection.ensureIndex(

diff --git a/lib/utils.js b/lib/utils.js
@@ -3,14 +3,8 @@ const MongoError = require('./core/error').MongoError;
 const ReadPreference = require('./core/topologies/read_preference');
 const WriteConcern = require('./write_concern');
 
-var shallowClone = function(obj) {
-  var copy = {};
-  for (var name in obj) copy[name] = obj[name];
-  return copy;
-};
-
 // Figure out the read preference
-var translateReadPreference = function(options) {
+function translateReadPreference(options) {
   var r = null;
   if (options.readPreference) {
     r = options.readPreference;
@@ -733,7 +727,6 @@ module.exports = {
   filterOptions,
   mergeOptions,
   translateOptions,
-  shallowClone,
   getSingleProperty,
   checkCollectionName,
   toError,