Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make cluster's project id non-computed attribute and add constant-ness check #44

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Jun 26, 2024

Zrzut ekranu 2024-06-26 o 11 10 53

Fixes PROD-2308 PROD-2328.

Closes #43 as it covers the same issue.

@maciaszczykm maciaszczykm changed the title fix: Make cluster's project id non-computed attribute and add constant-ness validator fix: Make cluster's project id non-computed attribute and add constant-ness check Jun 26, 2024
@maciaszczykm maciaszczykm marked this pull request as ready for review June 26, 2024 09:24
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So with this pr we'd never backfill the project data from the apis state I'm guessing?

Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks correct. One thing i'm wondering is what would happen for clusters that had the project id slurped into state from the prior versions but it isn't explicitly set? I suppose you can workaround it by just adding the project id explicitly?

@maciaszczykm
Copy link
Member Author

maciaszczykm commented Jun 26, 2024

So with this pr we'd never backfill the project data from the apis state I'm guessing?

Right, that's one of the flaws.

I think this looks correct. One thing i'm wondering is what would happen for clusters that had the project id slurped into state from the prior versions but it isn't explicitly set? I suppose you can workaround it by just adding the project id explicitly?

Yep, it should fix the issue if it will appear.

@maciaszczykm maciaszczykm merged commit 54d51db into main Jun 26, 2024
10 of 11 checks passed
@maciaszczykm maciaszczykm deleted the fix-cluster-project-bug branch June 26, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants