Add support for toggling templating on a service, and azure resource group config #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 0272815): https://pluralsh-console--pr691-mjg-eng-1766-add-api-xidg6a3b.web.app (expires Fri, 23 Feb 2024 05:43:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce |
michaeljguarino
force-pushed
the
mjg/eng-1766-add-api-support-for-liquid-template-disabling
branch
from
791bf75
to
9a1b9c2
Compare
…roup config Need the latter for velero setup. Also realized service secret fetching is very effectively cacheable, so doing that.
michaeljguarino
force-pushed
the
mjg/eng-1766-add-api-support-for-liquid-template-disabling
branch
from
9a1b9c2
to
8332d7a
Compare
* external token only for admins * k8s queries on mgmt cluster (OSS cluster) require operator role
maciaszczykm
approved these changes
Feb 16, 2024
maciaszczykm
deleted the
mjg/eng-1766-add-api-support-for-liquid-template-disabling
branch
snikch
pushed a commit
to snikch/plural-console
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Need the latter for velero setup. Also realized service secret fetching is very effectively cacheable, so doing that.
Test Plan
regression
Checklist