Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup/Restore data definitions, Service Context CRUD #637

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

michaeljguarino
Copy link
Member

Summary

Added basic schema defs for backup/restore, and also implemented a service context api. The general premise is a reusable, named block of config that can be communicated between tools, eg pulumi/terraform, then bound by name to a service to reconfigure it as needed.

Test Plan

unit

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added the enhancement New feature or request label Jan 28, 2024
@michaeljguarino michaeljguarino requested a review from a team January 28, 2024 22:48
Added basic schema defs for backup/restore, and also implemented a service context api.  The general premise is a reusable, named block of config that can be communicated between tools, eg pulumi/terraform, then bound by name to a service to reconfigure it as needed.
Copy link
Contributor

github-actions bot commented Jan 28, 2024

Visit the preview URL for this PR (updated for commit 58ecaf3):

https://pluralsh-console--pr637-backup-restore-mdu63j1b.web.app

(expires Mon, 05 Feb 2024 16:37:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@zreigz
Copy link
Member

zreigz commented Jan 29, 2024

we also need Get/List methods

@michaeljguarino
Copy link
Member Author

This wouldn't pool quite the same as the others, the general strategy I'm thinking is you can use the myCluster query already accessible by the agent and sideload the active restore from there. But a get is prob still needed, yeah

@michaeljguarino michaeljguarino merged commit 7865806 into master Jan 29, 2024
11 of 12 checks passed
@michaeljguarino michaeljguarino deleted the backup-restore branch April 16, 2024 01:41
snikch pushed a commit to snikch/plural-console that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants