fix: Add domain uniqueness check to the installer and update plural context query API #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit b9afd7e): https://pluralsh-console--pr355-wizard-domain-jbmeij9w.web.app (expires Wed, 24 May 2023 13:09:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce |
maciaszczykm
approved these changes
May 17, 2023
floreks
commented
May 22, 2023
There was a problem hiding this comment.
@michaeljguarino could you take a look at the elixir part?
michaeljguarino
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Similar to pluralsh/plural#1102
I have also noticed that
pluralContextquery does not return buckets and domains. I have updated API to support that.Test Plan
Locally + updated API unit test
Checklist