Implement command palette #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljguarino
added
enhancement
|
Visit the preview URL for this PR (updated for commit 44b1c11): https://pluralsh-console--pr353-kbar-tdd9xt8s.web.app (expires Fri, 19 May 2023 13:08:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce |
michaeljguarino
force-pushed
the
kbar
branch
2 times, most recently
from
74b473c
to
44b1c11
Compare
assets/package.json
Outdated
| @@ -67,6 +67,7 @@ | |||
| "js-file-download": "0.4.12", | |||
| "js-yaml": "4.1.0", | |||
| "jsonpath": "1.1.1", | |||
| "kbar": "^0.1.0-beta.40", | |||
There was a problem hiding this comment.
Can you change to 0.1.0-beta.40?
| } | ||
|
|
||
| function buildActions(applications, nav) { | ||
| console.log(applications) |
| // icon: <BuildIcon />, | ||
| // section: 'Cluster', | ||
| // perform: () => navigate('/builds'), | ||
| // }), |
There was a problem hiding this comment.
Should it stay commented out?
maciaszczykm
approved these changes
May 31, 2023
michaeljguarino
force-pushed
the
kbar
branch
2 times, most recently
from
d05fef3
to
e87f566
Compare
Currently supports basic app nav, but will also integrate the ai endpoint functionality too
michaeljguarino
force-pushed
the
kbar
branch
3 times, most recently
from
2b26350
to
d100d22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently supports basic app nav, but will also integrate the ai endpoint functionality too
Test Plan
local + unit tests
Checklist