Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max header length #350

Merged
merged 1 commit into from
May 2, 2023
Merged

Increase max header length #350

merged 1 commit into from
May 2, 2023

Conversation

michaeljguarino
Copy link
Member

Summary

I've noticed a lot of cookie length issues in console installs, this should fix those potentially, but if they keep cropping up, we need to consider removing some cookie stuff.

Test Plan

n/a

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

I've noticed a lot of cookie length issues in console installs, this should fix those potentially, but if they keep cropping up, we need to consider removing some cookie stuff.
@michaeljguarino michaeljguarino added bug-fix This pull request fixes a bug backend Changes related to the backend labels May 2, 2023
@michaeljguarino michaeljguarino requested a review from a team May 2, 2023 04:00
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Visit the preview URL for this PR (updated for commit 6334903):

https://pluralsh-console--pr350-header-length-kradxkzw.web.app

(expires Tue, 09 May 2023 04:03:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@michaeljguarino michaeljguarino merged commit 8625c22 into master May 2, 2023
@michaeljguarino michaeljguarino deleted the header-length branch May 2, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes related to the backend bug-fix This pull request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants