Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Data syncing issue with virtualized lists #342

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

dogmar
Copy link
Collaborator

@dogmar dogmar commented Apr 11, 2023

Updated all mapper functions in <StandardScroller> components to have key props set. This fixes issue with component states getting out of sync with the underlying data.

@dogmar dogmar requested a review from a team April 11, 2023 22:23
@dogmar dogmar added the bug-fix This pull request fixes a bug label Apr 11, 2023
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit b72e0f9):

https://pluralsh-console--pr342-klink-fix-virtualize-p6t1m52j.web.app

(expires Tue, 18 Apr 2023 22:24:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@dogmar dogmar marked this pull request as ready for review April 11, 2023 22:26
@dogmar dogmar added the frontend Changes related to the frontend label Apr 12, 2023
@dogmar dogmar merged commit 307acc8 into master Apr 12, 2023
@dogmar dogmar deleted the klink/fix-virtualized-lists branch April 12, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug frontend Changes related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants