Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support searching for apps #34

Merged
merged 1 commit into from
Feb 25, 2022
Merged

support searching for apps #34

merged 1 commit into from
Feb 25, 2022

Conversation

ycryptx
Copy link
Contributor

@ycryptx ycryptx commented Feb 24, 2022

Summary

Adds support for searching for installed apps in the toolbar of Console.
Closes #27
Screen Shot 2022-02-25 at 10 23 57 AM
Screen Shot 2022-02-25 at 10 23 49 AM

Test Plan

Checklist

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@ycryptx ycryptx added the enhancement New feature or request label Feb 24, 2022
@ycryptx ycryptx self-assigned this Feb 24, 2022
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you paste in a screenshot of the visual change? My guess is the flyout just has the search bar at the top?

onChange={({target: {value}}) => setQ(value)} />
</Box>
{applications
.filter((application) => q ? application.name.startsWith(q) : true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be fancy and do !q || application.name.startsWith(q)

Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ycryptx ycryptx merged commit e02f4df into master Feb 25, 2022
@michaeljguarino michaeljguarino deleted the search-for-installed-apps branch February 25, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Add support for searching for installed applications in the console
2 participants