Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: List component improvements #285

Merged
merged 7 commits into from
Feb 16, 2023
Merged

fix: List component improvements #285

merged 7 commits into from
Feb 16, 2023

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Feb 16, 2023

Summary

Refactored list component and removed some unused variables. Switched to native HTML tags where it was possible.

Test Plan

Locally.

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@maciaszczykm maciaszczykm added the enhancement New feature or request label Feb 16, 2023
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 1fe46d5):

https://pluralsh-console--pr285-marcin-list-item-v94x08t7.web.app

(expires Thu, 23 Feb 2023 12:16:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@maciaszczykm maciaszczykm requested a review from a team February 16, 2023 12:17
@maciaszczykm maciaszczykm merged commit 989da8e into master Feb 16, 2023
@maciaszczykm maciaszczykm deleted the marcin/list-item branch February 16, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants