Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update component detail views #269

Merged
merged 3 commits into from
Feb 9, 2023
Merged

feat: Update component detail views #269

merged 3 commits into from
Feb 9, 2023

Conversation

maciaszczykm
Copy link
Member

@maciaszczykm maciaszczykm commented Feb 9, 2023 •
edited
Loading

Summary

Moved metadata into info tab. Put metrics graphs into 2 columns.

Zrzut ekranu 2023-02-9 o 10 58 22

Zrzut ekranu 2023-02-9 o 10 58 12

Test Plan

Locally.

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@maciaszczykm maciaszczykm added the enhancement New feature or request label Feb 9, 2023
@maciaszczykm maciaszczykm requested a review from a team February 9, 2023 10:00
@maciaszczykm maciaszczykm changed the title Update component detail views feat: Update component detail views Feb 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Visit the preview URL for this PR (updated for commit 11fc5cb):

https://pluralsh-console--pr269-marcin-detail-views-twflgyjk.web.app

(expires Thu, 16 Feb 2023 10:03:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

floreks
floreks approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@floreks floreks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@maciaszczykm maciaszczykm merged commit 6318d14 into master Feb 9, 2023
@maciaszczykm maciaszczykm deleted the marcin/detail-views branch February 9, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floreks floreks floreks approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciaszczykm @floreks