Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get a full list of repos for the installer #264

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 8, 2023

Summary

Used custom repositories query for the installer to get an actually full list of repositories (SEARCH_REPOS only gets first 20). Since wizard does not support proper pagination/virtual scrolling right now, we can't benefit from using query param in the GQL query.

Test Plan

Locally

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@floreks floreks added bug-fix This pull request fixes a bug frontend Changes related to the frontend labels Feb 8, 2023
@floreks floreks self-assigned this Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Visit the preview URL for this PR (updated for commit 307a0e7):

https://pluralsh-console--pr264-wizard-repo-query-w67s634q.web.app

(expires Wed, 15 Feb 2023 09:24:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@floreks floreks merged commit 1949a15 into master Feb 8, 2023
@floreks floreks deleted the wizard/repo-query branch February 8, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This pull request fixes a bug frontend Changes related to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants