Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block conf updates during deployments #258

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

michaeljguarino
Copy link
Member

Summary

Noticed this can sometimes happen esp if git is slow, this should prevent it entirely

Test Plan

existing

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino added bug-fix This pull request fixes a bug backend Changes related to the backend labels Feb 7, 2023
@michaeljguarino michaeljguarino requested a review from a team February 7, 2023 02:54
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

Visit the preview URL for this PR (updated for commit efbd52a):

https://pluralsh-console--pr258-block-conf-updates-mxc7yxp3.web.app

(expires Wed, 15 Feb 2023 02:15:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

Noticed this can sometimes happen esp if git is slow, this should prevent it entirely
@michaeljguarino michaeljguarino merged commit ccbb6c1 into master Feb 8, 2023
@michaeljguarino michaeljguarino deleted the block-conf-updates branch February 8, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes related to the backend bug-fix This pull request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants