Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role search #229

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add role search #229

merged 1 commit into from
Jan 30, 2023

Conversation

michaeljguarino
Copy link
Member

@michaeljguarino michaeljguarino commented Jan 30, 2023 •
edited
Loading

Summary

Simply imitate the other search queries

Test Plan

added test

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino
Add role search
e1f9e59 
Simply imitate the other search queries
@michaeljguarino michaeljguarino added enhancement New feature or request backend Changes related to the backend labels Jan 30, 2023
@michaeljguarino michaeljguarino requested a review from a team January 30, 2023 14:12
@github-actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit e1f9e59):

https://pluralsh-console--pr229-add-roles-search-wroh1lzb.web.app

(expires Mon, 06 Feb 2023 14:17:42 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@michaeljguarino michaeljguarino merged commit 2980939 into master Jan 30, 2023
@michaeljguarino michaeljguarino deleted the add-roles-search branch January 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

Assignees
No one assigned
Labels
backend Changes related to the backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljguarino @maciaszczykm