Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose optional field on the recipe configuration #216

Merged
merged 2 commits into from
Jan 25, 2023
Merged

feat: Expose optional field on the recipe configuration #216

merged 2 commits into from
Jan 25, 2023

Conversation

floreks
Copy link
Member

@floreks floreks commented Jan 24, 2023

Summary

It is needed by the installer to properly determine if input fields should be required or not.

Test Plan

Locally

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@floreks floreks added enhancement New feature or request backend Changes related to the backend labels Jan 24, 2023
@floreks floreks self-assigned this Jan 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2023 •
edited
Loading

Visit the preview URL for this PR (updated for commit 671ae0d):

https://pluralsh-console--pr216-expose-recipe-option-idgekzkd.web.app

(expires Wed, 01 Feb 2023 08:53:51 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@floreks floreks mentioned this pull request Jan 24, 2023
Merged
4 tasks
@floreks floreks merged commit 841afbd into master Jan 25, 2023
@floreks floreks deleted the expose/recipe-optional-field branch January 25, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

Assignees

@floreks floreks

Labels
backend Changes related to the backend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floreks @michaeljguarino