Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pod watcher timeout #198

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add pod watcher timeout #198

merged 1 commit into from
Jan 13, 2023

Conversation

michaeljguarino
Copy link
Member

Summary

for our prod clusters, and those similar, the list endpoint is so slow, this timeout needs to be extended

Test Plan

on existing cluster

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@michaeljguarino michaeljguarino requested a review from a team January 13, 2023 03:30
@michaeljguarino michaeljguarino added bug-fix This pull request fixes a bug backend Changes related to the backend labels Jan 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 13, 2023

Visit the preview URL for this PR (updated for commit 014f19c):

https://pluralsh-console--pr198-add-pod-watcher-time-de36rsg1.web.app

(expires Fri, 20 Jan 2023 06:05:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

@michaeljguarino michaeljguarino force-pushed the add-pod-watcher-timeout branch 2 times, most recently from 6e25c81 to c6abcbc Compare January 13, 2023 05:07
for our prod clusters, and those similar, the list endpoint is so slow, this timeout needs to be extended
@davidspek
Copy link
Contributor

Can confirm that this build is broken.

12:51:38.293 [info] Registering leader #PID<0.4551.0> on #PID<0.4551.0>
12:51:38.549 [error] GenServer #PID<0.4551.0> terminating
** (Protocol.UndefinedError) protocol Console.GraphQl.Topic not implemented for %Kazan.Apis.Core.V1.PodList{api_version: "v1", items: nil, kind: "Pod", metadata: %Kazan.Models.Apimachinery.Meta.V1.ListMeta{continue: nil, remaining_item_count: nil, resource_version: "936046332", self_link: nil}} of type Kazan.Apis.Core.V1.PodList (a struct). This protocol is implemented for the following type(s): Console.Schema.Notification, Console.Schema.Build, Kube.Application, Kazan.Apis.Core.V1.Pod, Console.Schema.Command
    (console 0.3.23-dev.2-gc78f3fd+dirty) lib/console/graphql/topic.ex:1: Console.GraphQl.Topic.impl_for!/1
    (console 0.3.23-dev.2-gc78f3fd+dirty) lib/console/graphql/topic.ex:3: Console.GraphQl.Topic.infer/2
    (console 0.3.23-dev.2-gc78f3fd+dirty) lib/console/services/base.ex:57: Console.Services.Base.broadcast/2
    (console 0.3.23-dev.2-gc78f3fd+dirty) lib/console/watchers/pod.ex:20: Console.Watchers.Pod.handle_info/2
    (stdlib 3.14.1) gen_server.erl:689: :gen_server.try_dispatch/4
    (stdlib 3.14.1) gen_server.erl:765: :gen_server.handle_msg/6
    (stdlib 3.14.1) proc_lib.erl:226: :proc_lib.init_p_do_apply/3
Last message: %Kazan.Watcher.Event{from: #PID<0.4555.0>, object: %Kazan.Apis.Core.V1.PodList{api_version: "v1", items: nil, kind: "Pod", metadata: %Kazan.Models.Apimachinery.Meta.V1.ListMeta{continue: nil, remaining_item_count: nil, resource_version: "936046332", self_link: nil}}, type: :modified}
12:51:38.615 [info] Beginning leader election for Elixir.Console.Watchers.Pod, leader=#PID<0.4582.0>, proc=#PID<0.4582.0>, cert=#PID<0.4585.0>
12:51:38.615 [info] proc=#PID<0.4582.0>, cert=#PID<0.4585.0> Assuming leadership for Elixir.Console.Watchers.Pod

A previous commit of the PR before it was force pushed does seem to work though. That is, it doesn't crash loop.

@michaeljguarino michaeljguarino merged commit 5c864ad into master Jan 13, 2023
@michaeljguarino michaeljguarino deleted the add-pod-watcher-timeout branch January 13, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes related to the backend bug-fix This pull request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants