Cache command output locally #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljguarino
added
enhancement
|
Visit the preview URL for this PR (updated for commit be9f105): https://pluralsh-console--pr184-build-cache-1okj9973.web.app (expires Wed, 18 Jan 2023 20:52:50 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce |
michaeljguarino
force-pushed
the
build-cache
branch
from
602e1f7
to
4ab7cb2
Compare
maciaszczykm
approved these changes
Jan 9, 2023
floreks
approved these changes
Jan 11, 2023
We currently only persist command output per-line, which works except that a lot of commands have very long pauses per-line. Use in-memory caching to save overusing the database for this, and have a fallback when the cache misses to what's currently persisted to approximate a continuous db-write.
michaeljguarino
force-pushed
the
build-cache
branch
from
4ab7cb2
to
be9f105
Compare
davidspek
pushed a commit
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We currently only persist command output per-line, which works except that a lot of commands have very long pauses per-line. Use in-memory caching to save overusing the database for this, and have a fallback when the cache misses to what's currently persisted to approximate a continuous db-write.
Test Plan
existing tests pass, will try a live test after merge
Checklist