Don't drain protected services #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing those for string types even though it's prob invalid. Rejecting them here.
michaeljguarino
force-pushed
the
handle-empty-string
branch
7 times, most recently
from
2149bc8
to
36e2bb3
Compare
floreks
approved these changes
Sep 20, 2024
michaeljguarino
force-pushed
the
handle-empty-string
branch
from
36e2bb3
to
9355a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this gives us a bail-out from the standard drain behavior on controllers, allowing them to stick around and clean up deleted crds
Test Plan
unit test
Checklist