Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty strings in string pr automation context #1393

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Handle empty strings in string pr automation context #1393

merged 1 commit into from
Sep 17, 2024

Conversation

michaeljguarino
Copy link
Member

We were passing those for string types even though it's prob invalid. Rejecting them here.

Test Plan

unit test

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.

@michaeljguarino
Handle empty strings in string pr automation context
da7afa2 
We were passing those for string types even though it's prob invalid.  Rejecting them here.
@michaeljguarino michaeljguarino added the enhancement New feature or request label Sep 17, 2024
@michaeljguarino michaeljguarino requested a review from a team September 17, 2024 16:16
@michaeljguarino michaeljguarino merged commit 65eab4f into master Sep 17, 2024
9 checks passed
@michaeljguarino michaeljguarino deleted the handle-empty-string branch September 17, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemywingz seemywingz seemywingz approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaeljguarino @seemywingz