Observer api fixes #1382
Merged
Observer api fixes #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljguarino
force-pushed
the
fix-observer-apis
branch
3 times, most recently
from
2456694
to
db90f57
Compare
- [x] on_replace setting for errors
michaeljguarino
force-pushed
the
fix-observer-apis
branch
from
db90f57
to
8bfa677
Compare
michaeljguarino
force-pushed
the
fix-observer-apis
branch
5 times, most recently
from
81359f7
to
ab3c7b8
Compare
michaeljguarino
force-pushed
the
fix-observer-apis
branch
from
ab3c7b8
to
86bfff5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
e2e plus unit tests