-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add node drain functionality to dashboard #1376
feat: Add node drain functionality to dashboard #1376
Conversation
…d-cordondrain-to-nodes-view-in-k8s-dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and like sebastian said, we should probably have a toggle for ignoring daemonsets (default the toggle to on since that's more reasonable)
…d-cordondrain-to-nodes-view-in-k8s-dashboard
Added a toggle. We will need to improve error handling in places where we use dashboard API. It's probably connected to Apollo REST link that we use. It's not showing full error that dashboard normally returns. |
Test Plan
Checklist