feat: Resync resources in the namespaces on NamespaceCredential changes #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Setting max concurrent reconciles is a hard requirement for current namespace credentials implementation. | ||
| // Following watch ensures that if namespaced credentials change, all objects that use them will be reconciled. | ||
| WithOptions(controller.Options{MaxConcurrentReconciles: 1}). | ||
| Watches(&v1alpha1.NamespaceCredentials{}, handler.EnqueueRequestsFromMapFunc(func(ctx context.Context, nc client.Object) []reconcile.Request { |
There was a problem hiding this comment.
Is there no way to DRY up these EnqueueRequestsFromMapFunc handlers? Maybe generics could help or something?
There was a problem hiding this comment.
I will give it another try as at the first attempt I had problem with interface for list object that client uses to list resources.
|
Converting to draft to connect secret with namespace credentials, so we will have full event propagation for token changes. Edit: Reminder to merge |
|
Added logic to recreate service account secret if it gets deleted. |
michaeljguarino
approved these changes
Jul 8, 2024
maciaszczykm
deleted the
marcin/prod-2387-resync-resources-in-the-namespaces-on-namespacecredential
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.