-
Notifications
You must be signed in to change notification settings - Fork 2
v0.46.1 release #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.46.1 release #349
Conversation
|
Warning Rate limit exceeded@bouwew has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 9 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughReplaces the "Ongoing" header in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (3)
CHANGELOG.md (3)
3-3: Align version header formatting with 0.46.0 (drop the leading "v").Previous section uses "0.46.0" (no "v"). Suggest staying consistent.
Apply:
-## v0.46.1 - 2025-09-25 +## 0.46.1 - 2025-09-25Please also confirm the release date is correct for this cut.
8-8: Clarify/capitalize “plus-device”.Prior entries use “Plus devices” and “Circle+”. Recommend one of:
- “Plus device” (matches earlier “Plus devices”), or
- “Circle+ device” (if that’s what you mean).
Proposed minimal fix:
-- PR [344](https://github.com/plugwise/python-plugwise-usb/pull/344): Don't store plus-device in nodetypes cache. +- PR [344](https://github.com/plugwise/python-plugwise-usb/pull/344): Don't store Plus device in nodetypes cache.If Circle+ is intended, use:
- Don't store plus-device in nodetypes cache. + Don't store Circle+ device in nodetypes cache.
5-5: Tighten phrasing to avoid repetition.-- PR [337](https://github.com/plugwise/python-plugwise-usb/pull/337): Improve node removal, remove and reset the node as executed by Source, and remove the cache-file. +- PR [337](https://github.com/plugwise/python-plugwise-usb/pull/337): Improve node removal: perform remove-and-reset as done by Source, and delete the cache file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 36 36
Lines 8140 8140
=======================================
Hits 6657 6657
Misses 1483 1483 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|



Summary by CodeRabbit