Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Sep 24, 2025

Summary by CodeRabbit

  • Documentation
    • Added a new v0.46.1 (2025-09-25) changelog entry.
    • Summarizes improvements to node removal/reset behavior, caching (node types and device data), cache-file writing reliability, and auto-joining stability.
    • Preserves prior version history below the new entry.

@coderabbitai
Copy link

coderabbitai bot commented Sep 24, 2025

Warning

Rate limit exceeded

@bouwew has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 30a0a08 and b1ea532.

📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)

Walkthrough

Replaces the "Ongoing" header in CHANGELOG.md with a new release header "v0.46.1 - 2025-09-25" and adds changelog entries for PRs 337, 342, 343, 344, and 348; earlier version history remains unchanged.

Changes

Cohort / File(s) Summary of Changes
Documentation
CHANGELOG.md
Replaced "Ongoing" with header v0.46.1 - 2025-09-25; added entries for PRs 337, 342, 343, 344, and 348 describing node removal/reset behavior, node_type caching, cache-file writing fixes, plus-device caching, and auto-joining fixes; corrected a typo ("chaching" → "caching"); preserved prior version history below.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I hop through the changelog, nibbling lines so neat,
v0.46.1 arrives with a quick little beat—
Caches snug in corners, joins put in place,
Nodes reset tidy, no crumbs to trace.
Thump-thump—another carrot committed, sweet! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "v0.46.1 release" succinctly and accurately reflects the primary change in this branch, which is the release/version bump and changelog update to v0.46.1; it directly matches the changeset that adds a v0.46.1 header and entries to CHANGELOG.md. The phrasing is concise, specific to the main change, and readable for teammates scanning history. It does not include irrelevant noise or vague wording.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
CHANGELOG.md (3)

3-3: Align version header formatting with 0.46.0 (drop the leading "v").

Previous section uses "0.46.0" (no "v"). Suggest staying consistent.

Apply:

-## v0.46.1 - 2025-09-25
+## 0.46.1 - 2025-09-25

Please also confirm the release date is correct for this cut.


8-8: Clarify/capitalize “plus-device”.

Prior entries use “Plus devices” and “Circle+”. Recommend one of:

  • “Plus device” (matches earlier “Plus devices”), or
  • “Circle+ device” (if that’s what you mean).

Proposed minimal fix:

-- PR [344](https://github.com/plugwise/python-plugwise-usb/pull/344): Don't store plus-device in nodetypes cache.
+- PR [344](https://github.com/plugwise/python-plugwise-usb/pull/344): Don't store Plus device in nodetypes cache.

If Circle+ is intended, use:

- Don't store plus-device in nodetypes cache.
+ Don't store Circle+ device in nodetypes cache.

5-5: Tighten phrasing to avoid repetition.

-- PR [337](https://github.com/plugwise/python-plugwise-usb/pull/337): Improve node removal, remove and reset the node as executed by Source, and remove the cache-file.
+- PR [337](https://github.com/plugwise/python-plugwise-usb/pull/337): Improve node removal: perform remove-and-reset as done by Source, and delete the cache file.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a56a74 and db87283.

📒 Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.78%. Comparing base (3a56a74) to head (b1ea532).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          36       36           
  Lines        8140     8140           
=======================================
  Hits         6657     6657           
  Misses       1483     1483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bouwew bouwew marked this pull request as ready for review September 24, 2025 15:54
@bouwew bouwew requested a review from a team as a code owner September 24, 2025 15:54
@sonarqubecloud
Copy link

@bouwew bouwew merged commit 17837d9 into main Sep 24, 2025
17 checks passed
@bouwew bouwew deleted the 0_46_1 branch September 24, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants