Adjust ruff file targeting #268
Conversation
WalkthroughThe updates modify how Ruff linting and formatting commands target files in both GitHub Actions and a shell script, switching from directory-based to file-based patterns. The Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
CHANGELOG.md (1)
8-8: Include the PR number for consistency.The new entry is missing its PR reference. For clarity and traceability, prefix this line with
#268, e.g.:- - PR Maintenance chores Fix ruff reporting locally + - PR [#268](https://github.com/plugwise/python-plugwise-usb/pull/268): Maintenance chores Fix ruff reporting locally.github/workflows/verify.yml (1)
88-88: Quote glob patterns and align with local script.To satisfy ShellCheck and ensure ruff itself handles glob expansion, quote the patterns and use the same directory-targeting convention as in
scripts/tests_and_coverage.sh. For example:- ruff check plugwise_usb/* tests/* + ruff check "plugwise_usb/*" "tests/." ... - ruff format plugwise_usb/* tests/* + ruff format "plugwise_usb/*" "tests/*"This both silences SC2086 warnings and unifies CI with local lint commands.
Also applies to: 93-93
scripts/tests_and_coverage.sh (1)
68-68: Quote glob patterns and match workflow.Wrap the glob arguments in quotes to avoid ShellCheck warnings and align with the CI workflow:
- ruff check plugwise_usb/* tests/. # Does need the /* otherwise apparently skips __init__.py's + ruff check "plugwise_usb/*" "tests/." ... - ruff format plugwise_usb/* tests/* + ruff format "plugwise_usb/*" "tests/*"Consider using
tests/.*ortests/*consistently in both local and CI scripts to include__init__.py.Also applies to: 71-71
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
.github/workflows/verify.yml(1 hunks).gitignore(1 hunks)CHANGELOG.md(1 hunks)scripts/tests_and_coverage.sh(1 hunks)
🧰 Additional context used
🪛 actionlint (1.7.7)
.github/workflows/verify.yml
91-91: shellcheck reported issue in this script: SC2086:info:5:91: Double quote to prevent globbing and word splitting
(shellcheck)
91-91: shellcheck reported issue in this script: SC2086:info:6:14: Double quote to prevent globbing and word splitting
(shellcheck)
91-91: shellcheck reported issue in this script: SC2086:info:8:17: Double quote to prevent globbing and word splitting
(shellcheck)
🔇 Additional comments (1)
.gitignore (1)
19-19: Appropriate addition to ignore local data folder.Adding
appdata_folderwill prevent committing local application data. This aligns with existing ignore patterns.
Summary by CodeRabbit