Update to get network more stable (at startup and looping) #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dirixmjm
commented
Jan 13, 2024
dirixmjm
commented
- Push circle clock synchronisation into circle.py
- Change available/unavailable to info message making it easier to trace
- Add workaround to circle _last_log_address out of sync
- In logging self.mac => str(self.mac) otherwise sometimes we got a Python error
- Simplify synchronisation of PowerUpdate and EnergyCounters by changing calling structure _update_energy_today_now+
- Simplify history collection and network occupation on PlugWise startup by calculating missing addresses and calling off one address per PowerUpdate loop
- Calculate historal addresses based on know combination of address+timestamp+slot.
- Only call off PowerUpdate if NodePing was successful.
- temporary patchwork to keep sequence_id synced*
- Bump beta version
- Needs some more testing, but seems stable for now.
- The patchwork is not a final solution, but in favour of continuing work on the asnyc version, this will have to do for now.
add workaround to circle _last_log_address out of sync In logging self.mac => str(self.mac) otherwise sometimes we got a Python error Simplify synchronisation of PowerUpdate and EnergyCounters by changing calling structure _update_energy_today_now Simplify history collection and network occupation on PlugWise startup by calculating missing addresses and calling off one address per PowerUpdate loop Calculate historal addresses based on know combination of address+timestamp+slot. Only call off PowerUpdate if NodePing was successful. Bump beta version
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 34.80% 35.25% +0.44%
==========================================
Files 21 21
Lines 2428 2400 -28
==========================================
+ Hits 845 846 +1
+ Misses 1583 1554 -29 ☔ View full report in Codecov by Sentry. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.