Skip to content

Conversation

@dirixmjm
Copy link
Contributor

@dirixmjm dirixmjm commented Jan 4, 2024

8 days history was not used, only yesterday and today.

8 days history was not used, only yesterday and today.
@dirixmjm dirixmjm requested a review from a team as a code owner January 4, 2024 15:10
@codecov
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2e39dec) 34.84% compared to head (ea6f0c5) 34.80%.

Files Patch % Lines
plugwise_usb/nodes/circle.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   34.84%   34.80%   -0.05%     
==========================================
  Files          21       21              
  Lines        2425     2428       +3     
==========================================
  Hits          845      845              
- Misses       1580     1583       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Instead of steadily asking 13 addresses, only ask for the last 48 hours.
Forgot to delete intermediate variable name.
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you find an alternative to avoid importing math?

Use replacement for math.ceil to avoid additional import
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dirixmjm
Copy link
Contributor Author

dirixmjm commented Jan 4, 2024

ok, without math.ceil

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bouwew bouwew merged commit 92cb50f into main Jan 4, 2024
@bouwew bouwew deleted the mdi branch January 4, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants