make sure log addresses are unique inside history_failed_address #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
==========================================
- Coverage 34.85% 34.84% -0.02%
==========================================
Files 21 21
Lines 2424 2425 +1
==========================================
Hits 845 845
- Misses 1579 1580 +1 ☔ View full report in Codecov by Sentry. |
Contributor
|
Indeed, a log record contains 4 slots. Each slot consists of a timestamp and the number of energy pulses since the prior timestamp. The last log record does not have to have all slots populated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the log addresses each contain 4 hours of data and thus could be added to the history_failed_address multiple times, also when the update cycle rotates faster than the recalls of the failed adresses. Therefore it is good to prevent the addresses inside the array are unique.
Small update to the logging to include mac address for easier tracing.