Skip to content

Conversation

@dirixmjm
Copy link
Contributor

@dirixmjm dirixmjm commented Jan 1, 2024

rate limit unresponsive circle CircleEnergyCountersRequest to once every minute, while not blocking the initialisation process (e.g. energy_consumption_today) for responsive circles

…ery minute, while not blocking the initialisation process (e.g. energy_consumption_today) for responsive circles
@dirixmjm dirixmjm requested a review from a team as a code owner January 1, 2024 22:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4dda7d9) 35.01% compared to head (2b82b48) 35.00%.

Files Patch % Lines
plugwise_usb/nodes/circle.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   35.01%   35.00%   -0.02%     
==========================================
  Files          21       21              
  Lines        2413     2414       +1     
==========================================
  Hits          845      845              
- Misses       1568     1569       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bouwew bouwew merged commit 51f08c4 into plugwise:main Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants