Skip to content

Conversation

@dirixmjm
Copy link
Contributor

Prevent looping of CircleEnergyCountersRequests when no response is receivedceived from the circle

Remove loop code when faulty history response is received from CircleEnergyCountersRequest, with the last commit this code was not reachable anyway. A rerun of the history loop will take care of the faulty address later.

…eceived from the circle

Remove loop code when faulty history response is received from CircleEnergyCountersRequest, with the last commit this code was not reachable anyway. A rerun of the history loop will take care of the faulty address later.
@dirixmjm dirixmjm requested a review from a team as a code owner December 31, 2023 12:16
@CoMPaTech CoMPaTech added the bug Something isn't working label Dec 31, 2023
@codecov
Copy link

codecov bot commented Dec 31, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e8683d5) 35.04% compared to head (8531b6f) 35.01%.

Files Patch % Lines
plugwise_usb/nodes/circle.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   35.04%   35.01%   -0.03%     
==========================================
  Files          21       21              
  Lines        2411     2413       +2     
==========================================
  Hits          845      845              
- Misses       1566     1568       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me!

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@bouwew bouwew merged commit ffb6bd2 into plugwise:main Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants