Skip to content

Conversation

@CoMPaTech
Copy link
Member

No description provided.

@CoMPaTech CoMPaTech added the documentation Improvements or additions to documentation label Dec 30, 2023
@CoMPaTech CoMPaTech self-assigned this Dec 30, 2023
@CoMPaTech CoMPaTech requested a review from a team as a code owner December 30, 2023 10:20
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Dec 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (01fb120) 35.04% compared to head (afaa6dc) 35.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   35.04%   35.04%           
=======================================
  Files          21       21           
  Lines        2411     2411           
=======================================
  Hits          845      845           
  Misses       1566     1566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dirixmjm dirixmjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful addition.

@CoMPaTech
Copy link
Member Author

Seems to be working - welcome to the team. Feel free to hit the merge button so we know that also works :)

As for educational purposes; https://github.com/plugwise/python-plugwise-usb/actions/runs/7363514268/job/20043081248?pr=117#step:9:36 (if you show checks above the merge button, click details on Build and publish Python to TestPyPi -> it shows it will not create a new package as it already exists).

@dirixmjm dirixmjm merged commit e8683d5 into main Dec 30, 2023
@dirixmjm dirixmjm deleted the qual branch December 30, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants