Skip to content

Fix flooding of plugwise network by CircleEnergyCountersRequest (2nd try) #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 29, 2023
Merged

Fix flooding of plugwise network by CircleEnergyCountersRequest (2nd try) #111

merged 3 commits into from
Dec 29, 2023

Conversation

@dirixmjm
Copy link
Contributor

@dirixmjm dirixmjm commented Dec 28, 2023 •
edited by CoMPaTech
Loading

See #110 for original attempt
Hi Tom, let's try again.

@dirixmjm dirixmjm requested a review from a team as a code owner December 28, 2023 14:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 28, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

CoMPaTech
CoMPaTech approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CoMPaTech
Copy link
Member

CoMPaTech commented Dec 28, 2023

As for future, you could have just modified and changed the original PR, but no worries, this works as well.

@CoMPaTech
Copy link
Member

CoMPaTech commented Dec 28, 2023

Mergeable, the CodeFactor issue (finding a TODO) is existing code, ignoring.

@CoMPaTech
Copy link
Member

CoMPaTech commented Dec 28, 2023

@brefra @bouwew Can't release without merge as this is an incoming PR - so merging and releasing from there (we can always revert)

@CoMPaTech CoMPaTech changed the title Second try with proper indentation. Fix flooding of plugwise network by CircleEnergyCountersRequest (2nd try) Dec 28, 2023
@CoMPaTech CoMPaTech added bug Something isn't working enhancement New feature or request python Pull requests that update Python code labels Dec 28, 2023
@CoMPaTech CoMPaTech self-assigned this Dec 28, 2023
@CoMPaTech
Copy link
Member

CoMPaTech commented Dec 28, 2023

Little hold on this one (as not all actions have been run and I see @bouwew also tried something looking through the actions).

@CoMPaTech CoMPaTech self-requested a review December 28, 2023 14:20
@CoMPaTech CoMPaTech mentioned this pull request Dec 28, 2023
Merged
@bouwew bouwew merged commit 52653d4 into plugwise:main Dec 29, 2023
@bouwew
Copy link
Contributor

bouwew commented Dec 29, 2023

@dirixmjm You can test your updates by changing the plugwise_usb version to 0.31.1b0 in the manifest.json file of the plugwise_usb-beta custom_component in HA.

I've done that just now, the custom_component seems to load and function as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoMPaTech CoMPaTech Awaiting requested review from CoMPaTech

Assignees

@CoMPaTech CoMPaTech

Labels

bug Something isn't working enhancement New feature or request python Pull requests that update Python code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dirixmjm @CoMPaTech @bouwew