Skip to content

Conversation

@CoMPaTech
Copy link
Member

@CoMPaTech CoMPaTech commented Oct 8, 2025

Summary by CodeRabbit

  • Chores

    • Standardized tooling and CI to Python 3.14, including metadata updates declaring 3.14 support.
    • Simplified and stabilized CI caching for faster, more reliable runs.
    • Pre-commit now uses the system’s default Python for unspecified hooks.
  • Tests

    • Aligned test workflows to Python 3.14 across all jobs.
    • Centralized Python version selection from cache outputs for consistent environments.

@CoMPaTech CoMPaTech requested a review from a team as a code owner October 8, 2025 08:07
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Warning

Rate limit exceeded

@CoMPaTech has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 1095e28 and 26886f8.

📒 Files selected for processing (2)
  • .github/workflows/core_next.yml (4 hunks)
  • .github/workflows/test.yml (10 hunks)

Walkthrough

Updates CI to standardize on Python 3.14, centralize python-version via cache job outputs, and simplify cache keys by removing python-version from them. Pre-commit now uses the default Python interpreter. Project metadata/classifiers and pylint configuration are aligned to Python 3.14.

Changes

Cohort / File(s) Summary
CI workflows: cache/output flow and Python version
.github/workflows/core_next.yml, .github/workflows/test.yml
Set default/propagated Python to 3.14; cache job now outputs python-version; downstream jobs consume needs.cache.outputs.python-version; cache keys simplified to exclude python-version; cache version bumped in core_next and reset in test workflow.
Pre-commit configuration
.pre-commit-config.yaml
Switch default_language_version python from a fixed python3.13 to default.
Project metadata and tooling
pyproject.toml
Add Python 3.14 classifier; update pylint py-version to 3.14.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as GitHub Actions Runner
  participant Cache as Cache Job
  participant Prep as Prepare Job
  participant Test as Test/HA-Core Jobs

  Note over Dev,Cache: Workflow start
  Dev->>Cache: Setup Python (default 3.14) and compute cache key
  Cache-->>Dev: outputs.cache-key, outputs.python-version

  Note over Dev,Prep: Downstream jobs use cache outputs
  Dev->>Prep: uses needs.cache.outputs.python-version
  Prep-->>Dev: Prepared artifacts

  Dev->>Test: uses needs.cache.outputs.python-version
  Test-->>Dev: Test results

  Note right of Test: python-version now sourced from cache output<br/>instead of env default
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Python 3.13 #781 — Similar CI and metadata updates to Python versioning and tooling configuration.

Suggested labels

python, dependencies, enhancement, pre-commit

Suggested reviewers

  • bouwew
  • github-actions

Poem

Thump-thump goes my build-time heart, hooray!
I cached a carrot for a faster day.
3.14, my Python’s set—
Hops through jobs with no regret.
Keys trimmed neat, workflows aligned—
CI fields, perfectly rhymed. 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately summarizes the two main changes in the PR—updating the cache version and upgrading the Python runtime to 3.14—using concise, clear language that reflects the diff.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

@CoMPaTech CoMPaTech marked this pull request as draft October 8, 2025 08:39
@CoMPaTech
Copy link
Member Author

Needs more checking, but basics have improved now (still to check why it fails on release - though 2025.10 wasn't meant to be 3.14 compliant).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants