-
Notifications
You must be signed in to change notification settings - Fork 7
Add link to action attempt #889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe update modifies the issue body text in a GitHub Actions workflow. Now, when a test fails against the Home Assistant core development branch, the generated issue includes a direct URL to the relevant GitHub Actions run, allowing easier access to the action logs. No other workflow logic or code was changed. Changes
Poem
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/core_next.yml (1)
74-75: Prefer${{ github.server_url }}and YAML|block for portability & readabilityGreat idea to surface the run URL 👍.
Two minor tweaks will make the body more future-proof and easier to maintain:
- Self-hosted/enterprise runners won’t live under
https://github.com/. Using the built-in${{ github.server_url }}keeps the URL correct everywhere.- The current 300-char quoted string is hard to read and error-prone. A YAML block scalar (
|) is clearer and avoids escaping issues.- body: "**Note: This does not affect users of the plugwise integration in Core nor Plugwise-Beta users on the latest version of Home Assistant.** For our beloved {{ assignees }}, please check action logs, it seems our current code is not compatible with the upcoming version (and/or Release Candidate (RC)/beta) of Home Assistant in a timely matter to conform before the next monthly release. See details at https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}" + body: | + **Note: This does not affect users of the plugwise integration in Core nor Plugwise-Beta users on the latest version of Home Assistant.** + + For our beloved {{ assignees }}, please check the action logs – it seems our current code is not compatible with the upcoming version (and/or RC/beta) of Home Assistant in a timely manner to conform before the next monthly release. + + See details at ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/core_next.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Prepare
- GitHub Check: Prepare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Error while testing for Development HA-core:
✔️ Success: No problem with testing against released HA-core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Error while testing for Development HA-core:
✔️ Success: No problem with testing against released HA-core.
|
As per discord on #892 let's monitor the output (as it dit reply with 'dev failed' while there was nothing wrong. This PR is about adding the weekly dev build check |
bouwew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍



Summary by CodeRabbit