-
Notifications
You must be signed in to change notification settings - Fork 7
Bump plugwise to v1.7.6 #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes update versioning and dependency requirements for the Plugwise integration. The changelog is revised to reflect new release entries and dependency bumps. The manifest and project configuration files are updated to require plugwise version 1.7.6 and set the integration version to 0.57.4. Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
CHANGELOG.md (1)
5-9: Minor wording – CI chores already impliedNit: the first bullet (“Maintenance chores on CI”) is vague; consider dropping or expanding it to describe the actual change (e.g., updated workflow, caching, etc.).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)custom_components/plugwise/manifest.json(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Prepare
🔇 Additional comments (3)
custom_components/plugwise/manifest.json (2)
11-11: Version bump looks consistent
versionnow equals0.57.4, matching the CHANGELOG and pyproject entry.
No further action required.
10-10: ```shell
#!/usr/bin/env bashAttempt to fetch the CHANGELOG for 1.7.6 from both possible tag names
for tag in 1.7.6 v1.7.6; do
echo "=== CHANGELOG for tag $tag ==="
if curl -fsSL "https://raw.githubusercontent.com/plugwise/python-plugwise/${tag}/CHANGELOG.md"; then
echo
break
else
echo "Not found for tag $tag"
echo
fi
done</details> <details> <summary>pyproject.toml (1)</summary> `3-3`: **Project version downgraded – ensure the Git tag follows** The project version moved from `0.58.0` back to `0.57.4`. Before merging, confirm that: 1. A matching `v0.57.4` tag will be created. 2. Any pre-existing `v0.58.0` tag (if pushed) is deleted or marked pre-release to avoid confusion. </details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Error while testing for Development HA-core:
✔️ Success: No problem with testing against released HA-core.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Error while testing for Development HA-core:
✔️ Success: No problem with testing against released HA-core.



Via this update,
set_switch_state()in the plugwise backend doesn't raise an error when a locked switch is toggled.This corrects the behavior in the frontend: when a locked switch is toggled it will return to it's previous state after a few seconds.
At present, the switch toggles to the opposite state when clicked and stays in that state, which is wrong. Only after a browser-refresh the correct switch state is shown.
Summary by CodeRabbit