Skip to content

Some small updates #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Some small updates #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8b5b3c
Add comment describing reason for device_registry.async_get_or_create()
bouwew Sep 12, 2024
f790af1
Remove unneeded comment
bouwew Sep 12, 2024
98305fb
Use BINARY_SENSORS constant
bouwew Sep 12, 2024
5a87f79
Update CHANGELOG
bouwew Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

## Versions from 0.40 and up

## Ongoing

- Add comment, small improvement.

## v0.53.0

- New Feature: show model_id's of all devices (Adam, Anna, not for legacy gateways).
Expand Down
2 changes: 1 addition & 1 deletion custom_components/plugwise/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ async def async_setup_entry(hass: HomeAssistant, entry: PlugwiseConfigEntry) ->
model=coordinator.api.smile_model,
name=coordinator.api.smile_name,
sw_version=coordinator.api.smile_version,
)
) # required for adding the entity-less P1 Gateway

async def delete_notification(
call: ServiceCall,
Expand Down
3 changes: 1 addition & 2 deletions custom_components/plugwise/binary_sensor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,7 @@ def is_on(self) -> bool:
self.hass, message, "Plugwise Notification:", f"{DOMAIN}.{notify_id}"
)

# return self.device["binary_sensors"][self.entity_description.key] # type: ignore [literal-required]
return self.device["binary_sensors"][self.entity_description.key]
return self.device[BINARY_SENSORS][self.entity_description.key]

@property
def extra_state_attributes(self) -> Mapping[str, Any] | None:
Expand Down