Skip to content

Fix for self.hass.components.persistent_notification #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 25, 2024
Merged

Fix for self.hass.components.persistent_notification #705

merged 6 commits into from
Aug 25, 2024

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Aug 25, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Refactor
    • Simplified the creation of persistent notifications in the Plugwise integration for improved code readability without changing functionality.
  • Bug Fixes
    • Resolved an issue with the integration of the Plugwise component accessing persistent notifications, ensuring correct display when the relevant attribute is present.
  • Documentation
    • Updated the changelog to include a new section titled "Ongoing," reflecting ongoing improvements and fixes related to the Plugwise integration.

@bouwew bouwew requested a review from a team as a code owner August 25, 2024 12:22
@bouwew bouwew requested a review from CoMPaTech August 25, 2024 12:22
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 25, 2024 •
edited
Loading

Warning

Rate limit exceeded

@bouwew has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 0 minutes and 55 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 3e62860 and 064a58e.

Walkthrough

The changes involve a refactoring in the Plugwise integration for Home Assistant, specifically in the is_on method of the binary sensor entity. The code now imports the async_create function from homeassistant.components.persistent_notification instead of calling it directly via self.hass.components.persistent_notification. Additionally, the changelog has been updated to include a new section documenting fixes related to the 'plugwise' component's integration.

Changes

Files Change Summary
custom_components/plugwise/binary_sensor.py Refactored notification creation by importing async_create directly from persistent_notification.
CHANGELOG.md Updated to include a new "Ongoing" section detailing a fix for the 'plugwise' integration.

Poem

In the code where rabbits play,
Notifications now clear the way.
With a hop and a skip,
We've tightened the grip,
Making functions dance and sway! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Aug 25, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cf14dab and cce45c9.

Files selected for processing (1)
  • custom_components/plugwise/binary_sensor.py (2 hunks)
Files skipped from review due to trivial changes (1)
  • custom_components/plugwise/binary_sensor.py

CoMPaTech
CoMPaTech reviewed Aug 25, 2024
View reviewed changes
coderabbitai[bot]
coderabbitai bot requested changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cce45c9 and 3e62860.

Files selected for processing (1)
  • CHANGELOG.md (1 hunks)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bouwew bouwew merged commit 455afdc into main Aug 25, 2024
@bouwew bouwew deleted the persistent_notif branch August 25, 2024 12:59
@coderabbitai coderabbitai bot mentioned this pull request Sep 13, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

@CoMPaTech CoMPaTech CoMPaTech approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bouwew @CoMPaTech