-
Notifications
You must be signed in to change notification settings - Fork 7
Rework pre-commit prettier to biome #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pre-commit hooks in the project have been updated to utilize the Biome tool instead of Prettier, enhancing code formatting and linting capabilities. This change includes updating the repository source, modifying the hook ID, and introducing a new dependency on the Biome package. These adjustments signify a strategic move towards improved code quality management. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
Half-expecting pre-commit.ci to fail now :) |
|
And biome just works on pre-commit.ci :P |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .pre-commit-config.yaml (1 hunks)
Additional comments not posted (4)
.pre-commit-config.yaml (4)
61-61: Verify the repository change.The repository URL has been updated from Prettier to Biome. Ensure that Biome meets all the project's formatting and linting requirements.
64-64: Verify the hook ID change.The hook ID has been updated from
prettiertobiome-lint. Ensure that the new hook ID is correctly configured and functions as expected.
66-66: Verify the hook name change.The hook name has been updated to reflect the use of Biome instead of Prettier. Ensure that Biome provides the expected improvements and functionality.
65-65: Verify the additional dependency.The new dependency
@biomejs/biome@1.8.3has been added. Ensure that this dependency is correctly specified and compatible with the project.



Wrt comment @bouwew in plugwise/plugwise_usb-beta#143 and status of pre-commit/prettier
Summary by CodeRabbit
New Features
Bug Fixes