Add fullscreen option. #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the layout so that slides take the full space and webcam is over the slides.
|
Thank you! I'm not the maintainer but can I ask you to share a small screenshot? Maybe it can be useful to the maintainer to get an idea. Thanks! |
|
Yes, you can see the result in this video for instance: |
|
I tried on my computer and it just works great as expected. I just suggest to also mention this useful new option in the README. (I'm not the maintainer) |
|
Premising that I've done some code review, and I'm merging what I like in this fork: https://github.com/valerio-bozzolan/bbb-render Hoping to be useful, this pull request was merged in that fork, at this point: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the layout so that slides take the full space and webcam is over the slides. I like this layout more, and thought this might be useful to other people.